From 10a812dabf1518f68bb91e30ef05acd5514516a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Zurcher?= <jeremy@asynk.ch>
Date: Wed, 19 Nov 2014 10:16:16 +0100
Subject: Player: promote does all the job, returns boolean

---
 core/src/ch/asynk/tankontank/game/Player.java | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/core/src/ch/asynk/tankontank/game/Player.java b/core/src/ch/asynk/tankontank/game/Player.java
index ffca1a2..9bc1c2b 100644
--- a/core/src/ch/asynk/tankontank/game/Player.java
+++ b/core/src/ch/asynk/tankontank/game/Player.java
@@ -205,17 +205,16 @@ public class Player
         return false;
     }
 
-    public Unit promote(Unit unit)
+    public boolean promote(Unit unit)
     {
         for (Unit p: casualties) {
             if (p.isHqOf(unit)) {
-                units.remove(unit);
-                casualties.add(unit);
-                units.add(p);
-                casualties.remove(p);
-                return p;
+                unit.promote();
+                p.degrade();
+                return true;
             }
         }
-        return null;
+
+        return false;
     }
 }
-- 
cgit v1.1-2-g2b99